Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update radix-vue deps #941

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

sadeghbarati
Copy link
Collaborator

Close unovue/shadcn-vue#545

This PR will bump @internationalized pkg to latest and also fix sourcemap warning in Nuxt projects

@sadeghbarati
Copy link
Collaborator Author

sadeghbarati commented May 21, 2024

Build is failing because of TypeScript errors

@zernonia
Copy link
Member

Applied the TS fix by @DamianGlowala here 😁

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@zernonia
Copy link
Member

@sadeghbarati can you help check if the published version fix the issue mentioned? 😁

Copy link

pkg-pr-new bot commented May 21, 2024

Last Commit Build: 9499f1b

radix-vue(9499f1b):

npm i https://pkg.pr.new/radix-vue@9499f1b    

Pull Request Build: #941

radix-vue(#941):

npm i https://pkg.pr.new/radix-vue@941    

@sadeghbarati
Copy link
Collaborator Author

cc @Aslemammad

image

Looks like the custom registry blocked when we request from terminal?
Manually open the link and it will download something like

image

@Aslemammad
Copy link

With the iranian IP, i guess cf is blocked right now! Tried with a vpn and it worked!

@sadeghbarati
Copy link
Collaborator Author

https://stackblitz.com/edit/github-gwthzj

It's working @zernonia, it is without sourcemap warning

@sadeghbarati
Copy link
Collaborator Author

With the iranian IP, i guess cf is blocked right now! Tried with a vpn and it worked!

Right, Sigh, my V2ray config is not good enough

@zernonia zernonia merged commit 0d1109e into unovue:main May 21, 2024
5 checks passed
@sadeghbarati sadeghbarati deleted the update-deps branch May 21, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Toast - Failed to load source map for @internationalized/date
3 participants